[MEDIUM] Keep stores

[Ringthane]

Are misreported at the moment of keep's owner recruitment. Example, Utarg is recruited, keep shows 63 stores, 3 are consumed, 12 remain.

[sparrowhawk]

Sorry, meant to answer this one ages ago.

They are actually correctly reported, but the values set are bugs, if that makes sense! ie:

Currently the nightly increase in stores at a stronghold's granary does not check whether the increase will take the stores above the maximum.

However, once you select to transfer stores from such a place, the system creates an object and uses its adjustStores() method (a.k.a. function) to remove the consumed stores. Part of the check in that method checks for stores > max. Since the new level is still above the max, the code brings the level down to the max and then saves the record.

Phew. You really didn't need to know that, did you?

Incidentally, the same problem happens with Wise and Dragon courage. Courage is randomly set at the start of the game for all non-player lords. But dragons and wise have their courage fixed at maximum in the object. So looking ahead, you may see Cardofal as scared. Recruit and select him and suddenly he is utterly courageous.

Needs sorting out.